Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for zOS #4209

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Initial support for zOS #4209

merged 2 commits into from
Jul 18, 2023

Conversation

v1gnesh
Copy link
Contributor

@v1gnesh v1gnesh commented Jun 3, 2023 •
edited
Loading

zOS is an IBM Z (mainframe) operating system. In the days of yore, it was MVS.

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves - the inability to build on zOS.

Changes proposed in this pull request:

  • This PR adds a couple of files to allow building nats-server on zOS.

@v1gnesh
Initial support for zOS
fa2567a 
zOS is an IBM Z (mainframe) operating system. In the days of yore, it was MVS.

Signed-off-by: v1gnesh <v1gnesh@users.noreply.github.com>
@v1gnesh v1gnesh requested a review from a team as a code owner June 3, 2023 04:44
derekcollison
derekcollison reviewed Jun 3, 2023
View reviewed changes
server/pse/pse_zos.go Outdated Show resolved Hide resolved
server/pse/pse_zos.go Show resolved Hide resolved
server/sysmem/mem_zos.go Show resolved Hide resolved
@derekcollison
Copy link
Member

Let's target this one to merge to the dev branch for the next release.

@v1gnesh v1gnesh changed the base branch from main to dev June 5, 2023 12:48
bruth
bruth approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to @derekcollison on the final approval, but LGTM now that it targets dev. Thanks for the contribution!

@derekcollison derekcollison requested review from wallyqs and neilalexander and removed request for wallyqs and neilalexander July 18, 2023 19:19
@derekcollison derekcollison merged commit 3173d43 into nats-io:dev Jul 18, 2023
@v1gnesh v1gnesh deleted the zos branch July 19, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison left review comments

@bruth bruth bruth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1gnesh @derekcollison @bruth